Fidonet Portal

From: mark lewis (1:3634/12)
To: All
Date: Fri, 09.11.12 13:49
Bug found in osmscfnd.c
WvV>> In line 15 of osmscfnd.c it says:

WvV>> if (pff->handle == 0)

WvV>> This should be:

WvV>> if (pff->handle == -1)

WvV>> Because _findfirst(Wink returns a -1 on error:

ml> or if (pff->handle > -1)

ml> right?? do we want to look for a specific equal result or do we want to
ml> look for a result greater than -1??

WvV> The specs clearly say it returns -1 on error. So other negative
WvV> values could be valid handle values.

yeah, i got distracted and sent that before making the example i was really
trying to write... that was:

if (pff->handle < 0)

i can't say that i've even really known negative values to be non-error
related... but that's ok... you guys caught it and fixed it Smile


* Origin: (1:3634/12)


This forum contains echomail areas hosted on Nightmare BBS You can browse local echomail areas, italian fidonet areas and a selection of international fidonet areas, reading messages posted by users in Nightmare BBS or even other BBSs all over the world. You can find file areas too (functional to fidonet technology). You can browse echomail areas and download files with no registration, but if you want to write messages in echomail areas, or use fidonet netmail (private messages with fidomet technology), you have to register. Only a minimal set of data is required, functional to echomail and netmail usage (name, password, email); a registration and login with facebook is provided too, to allow easy registration. If you won't follow rules (each echomail areas has its own, regularly posted in the echomail), your account may be suspended;